Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add use case to check if backend supports personal to team migration (WPB-12022) #3114

Merged
merged 12 commits into from
Nov 22, 2024
Merged

feat: add use case to check if backend supports personal to team migration (WPB-12022) #3114

merged 12 commits into from
Nov 22, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 20, 2024 •
edited by github-actions bot
Loading

TaskWPB-12022 [Android] API V7 related client ticket

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Use case to check if backend supports personal to team account migration

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, borichellow, Garzas, saleniuk and damian-kaczmarek and removed request for a team November 20, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

Test Results

3 309 tests  +4   3 202 ✅ +4   4m 49s ⏱️ -21s
  565 suites +1     107 💤 ±0 
  565 files   +1       0 ❌ ±0 

Results for commit 953dfc9. ± Comparison against base commit 08c0cff.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024 •
edited
Loading

🐰 Bencher Report

Branchadd-use-case-to-check-if-backend-supports-personal-to-team-migration
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD		656,498.50
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD		389,933,952.42
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD		1,318,880,769.81
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD		21,506,707.53
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2024 •
edited
Loading

Datadog Report

Branch report: add-use-case-to-check-if-backend-supports-personal-to-team-migration
Commit report: 4c9990d
Test service: kalium-jvm

✅ 0 Failed, 3202 Passed, 107 Skipped, 34.41s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 34.37500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 54.02%. Comparing base (08c0cff) to head (953dfc9).

Files with missing lines Patch % Lines
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% 13 Missing ⚠️
...gic/configuration/server/ServerConfigRepository.kt 16.66% 5 Missing ⚠️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3114      +/-   ##
===========================================
- Coverage    54.03%   54.02%   -0.01%     
===========================================
  Files         1246     1247       +1     
  Lines        36152    36176      +24     
  Branches      3656     3658       +2     
===========================================
+ Hits         19534    19545      +11     
- Misses       15208    15221      +13     
  Partials      1410     1410
Files with missing lines Coverage Δ
...teamaccount/CanMigrateFromPersonalToTeamUseCase.kt 100.00% <100.00%> (ø)
...om/wire/kalium/logic/network/SessionManagerImpl.kt 51.61% <ø> (ø)
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 59.01% <0.00%> (-1.49%) ⬇️
...gic/configuration/server/ServerConfigRepository.kt 69.84% <16.66%> (-3.05%) ⬇️
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c0cff...953dfc9. Read the comment docs.

---- 🚨 Try these New Features:

@ohassine ohassine enabled auto-merge November 20, 2024 14:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ohassine ohassine disabled auto-merge November 20, 2024 16:49
MohamadJaara
MohamadJaara previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not 100% guarantied to be correct at run time, there is a small chance that an API version is updated after the user session is created therefore the update will not take place until the next app restart

to be 100% accurate you can get the server config from SessionManager.serverConfig()

@ohassine ohassine enabled auto-merge November 21, 2024 10:51
@ohassine ohassine dismissed MohamadJaara’s stale review November 21, 2024 10:51

comment addressed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ohassine ohassine dismissed MohamadJaara’s stale review November 22, 2024 08:31

comment addressed

@ohassine ohassine added this pull request to the merge queue Nov 22, 2024
Merged via the queue into develop with commit e271934 Nov 22, 2024
22 checks passed
@ohassine ohassine deleted the add-use-case-to-check-if-backend-supports-personal-to-team-migration branch November 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-kaczmarek damian-kaczmarek damian-kaczmarek approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@ohassine ohassine

Labels
echoes/initiative: personal-users-to-team-users... 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ohassine @codecov-commenter @yamilmedina @MohamadJaara @damian-kaczmarek